1panel-dev/1panel · Security
1Panel set-cookie is missing the Secure keyword
- GHSA ID
- GHSA-9xfw-jjq2-7v8h
- CVE ID
- CVE-2024-24768
- Severity
- low
- Published
- Updated
- CVSS
- 3.5 · CVSS:3.1/AV:N/AC:L/PR:L/UI:R/S:U/C:L/I:N/A:N
- CVSS v3
- 3.5 · CVSS:3.1/AV:N/AC:L/PR:L/UI:R/S:U/C:L/I:N/A:N
Description
Summary
The https cookie that comes with the panel does not have the Secure keyword, which may cause the cookie to be sent in plain text when accessing http accidentally.
https://developer.mozilla.org/zh-CN/docs/Web/HTTP/Headers/Set-Cookie#secure
PoC
Directly configure https for the panel, and then capture the packet when logging in again and find that the cookie does not have the Secure keyword
Impact
Everyone who has configured the panel https
CWEs
- CWE-311 · Missing Encryption of Sensitive Data
- CWE-315 · Cleartext Storage of Sensitive Information in a Cookie
References
- https://github.com/1Panel-dev/1Panel/security/advisories/GHSA-9xfw-jjq2-7v8h ↗
- https://nvd.nist.gov/vuln/detail/CVE-2024-24768 ↗
- https://github.com/1Panel-dev/1Panel/pull/3817 ↗
- https://github.com/1Panel-dev/1Panel/commit/1169648162c4b9b48e0b4aa508f9dea4d6bc50d5 ↗
- https://github.com/advisories/GHSA-9xfw-jjq2-7v8h ↗