denoland/deno · Security
deno_doc's HTML generator vulnerable to Cross-site Scripting
- GHSA ID
- GHSA-qqwr-j9mm-fhw6
- CVE ID
- CVE-2024-32468
- Severity
- low
- Published
- Updated
- CVSS
- 5.4 · CVSS:3.1/AV:N/AC:L/PR:L/UI:R/S:C/C:L/I:L/A:N
- CVSS v3
- 5.4 · CVSS:3.1/AV:N/AC:L/PR:L/UI:R/S:C/C:L/I:L/A:N
- CVSS v4
- 2 · CVSS:4.0/AV:N/AC:L/AT:N/PR:L/UI:P/VC:N/VI:N/VA:N/SC:L/SI:L/SA:N/E:P
Description
Summary
Several cross-site scripting vulnerabilities existed in the deno_doc crate which lead to Self-XSS with deno doc --html.
Details & PoC
1.) XSS in generated search_index.js
deno_doc outputed a JavaScript file for searching. However, the generated file used innerHTML on unsanitzed HTML input.
2.) XSS via property, method and enum names
deno_doc did not sanitize property names, method names and enum names.
Impact
The first XSS most likely didn't have an impact since deno doc --html is expected to be used locally with own packages.
CWEs
- CWE-79 · Improper Neutralization of Input During Web Page Generation ('Cross-site Scripting')
References
- https://github.com/denoland/deno/security/advisories/GHSA-qqwr-j9mm-fhw6 ↗
- https://github.com/denoland/deno_doc/commit/0f1ef3efbf16194730a29d93dcb9c02f6c490942 ↗
- https://github.com/denoland/deno_doc/blob/dc556c848831d7ae48f3eff2ababc6e75eb6b73e/src/html/templates/pages/search.js#L120-L144 ↗
- https://nvd.nist.gov/vuln/detail/CVE-2024-32468 ↗
- https://github.com/advisories/GHSA-qqwr-j9mm-fhw6 ↗