githubnewbie0/odf-kit · Security
odf-kit has HTML injection leading to XSS in odsToHtml() via unescaped style attribute values
- GHSA ID
- GHSA-2rqm-h6hv-g79v
- Severity
- medium
- Published
- Updated
- CVSS
- 6.1 · CVSS:3.1/AV:N/AC:L/PR:N/UI:R/S:C/C:L/I:L/A:N
- CVSS v3
- 6.1 · CVSS:3.1/AV:N/AC:L/PR:N/UI:R/S:C/C:L/I:L/A:N
Description
Summary
ODF style values are interpolated into style="..." attributes without HTML-escaping in odf-kit's ODS to-HTML renderer (odsToHtml()). A double-quote character inside an attacker-controlled style value breaks out of the attribute, allowing arbitrary HTML/attribute injection — and therefore script execution (XSS) — from a crafted .ods file wherever the rendered output is inserted as HTML, which is the documented purpose of the function.
Details
Two emission sites in src/ods/to-html/html-renderer.ts (before 0.14.0, src/ods-reader/html-renderer.ts) write document-controlled values into a style attribute without escaping:
- Cell style.
buildInlineStyle()assembles a CSS string from the cell's formatting properties (fo:color,fo:font-size,fo:font-family,fo:background-color,fo:text-align, etc.) with no escaping, andrenderCellemits it raw as the cell'sstyleattribute. - Row height.
row.height(fromstyle:row-height) is emitted raw into the row element'sstyleattribute.
The same defect in the ODT renderer (odtToHtml()) is tracked as GHSA-3cgg-c5pp-57h6 (CVE-2026-113787).
Impact
Any consumer that renders odsToHtml() output as HTML gets XSS from a crafted .ods file they convert: untrusted file → arbitrary tags and attributes → script execution in the host page with the page's origin.
Patches
Fixed in 0.14.2. Both sites now route document-controlled values through a shared attribute-escaping helper:
1424227: escape style attribute values in the ODS HTML rendereraa64c73: the sharedescapeAttrhelper
Users should upgrade to 0.14.2 or later.
Credit
Reported by @PethuKannan.
CWEs
- CWE-79 · Improper Neutralization of Input During Web Page Generation ('Cross-site Scripting')