identitypython/pysaml2 · Security
Improper Verification of Cryptographic Signature in PySAML2
- GHSA ID
- GHSA-5p3x-r448-pc62
- CVE ID
- CVE-2021-21239
- Severity
- medium
- Published
- Updated
- CVSS
- 6.5 · CVSS:3.1/AV:N/AC:L/PR:N/UI:R/S:U/C:N/I:H/A:N
- CVSS v3
- 6.5 · CVSS:3.1/AV:N/AC:L/PR:N/UI:R/S:U/C:N/I:H/A:N
- CVSS v4
- 6.9 · CVSS:4.0/AV:N/AC:L/AT:N/PR:N/UI:A/VC:N/VI:H/VA:N/SC:N/SI:N/SA:N
Description
Impact
All users of pysaml2 that use the default CryptoBackendXmlSec1 backend and need to verify signed SAML documents are impacted. pysaml2 <= 6.4.1 does not ensure that a signed SAML document is correctly signed. The default CryptoBackendXmlSec1 backend is using the xmlsec1 binary to verify the signature of signed SAML documents, but by default, xmlsec1 accepts any type of key found within the given document. xmlsec1 needs to be configured explicitly to only use only x509 certificates for the verification process of the SAML document signature.
Patches
Users should upgrade to pysaml2 v6.5.0.
Workarounds
No workaround provided at this point.
References
This issue has been reported in the past at the xmlsec1 mailing list: https://www.aleksey.com/pipermail/xmlsec/2013/009717.html
Credits
- Brian Wolff
For more information
If you have any questions or comments about this advisory:
- Open an issue in pysaml2
- Email us at the incident-response address
CWEs
- CWE-347 · Improper Verification of Cryptographic Signature
References
- https://github.com/IdentityPython/pysaml2/security/advisories/GHSA-5p3x-r448-pc62 ↗
- https://github.com/IdentityPython/pysaml2/commit/46578df0695269a16f1c94171f1429873f90ed99 ↗
- https://github.com/IdentityPython/pysaml2/releases/tag/v6.5.0 ↗
- https://pypi.org/project/pysaml2 ↗
- https://www.aleksey.com/pipermail/xmlsec/2013/009717.html ↗
- https://nvd.nist.gov/vuln/detail/CVE-2021-21239 ↗
- https://lists.debian.org/debian-lts-announce/2021/02/msg00038.html ↗
- https://github.com/pypa/advisory-database/tree/main/vulns/pysaml2/PYSEC-2021-49.yaml ↗
- https://github.com/advisories/GHSA-5p3x-r448-pc62 ↗