khoj-ai/khoj · Security
Khoj Open Redirect Vulnerability in Login Page
- GHSA ID
- GHSA-564j-v29w-rqr6
- Severity
- medium
- Published
- Updated
- CVSS
- 6.5 · CVSS:3.1/AV:N/AC:L/PR:N/UI:R/S:U/C:N/I:H/A:N
- CVSS v3
- 6.5 · CVSS:3.1/AV:N/AC:L/PR:N/UI:R/S:U/C:N/I:H/A:N
- CVSS v4
- 6.3 · CVSS:4.0/AV:N/AC:L/AT:N/PR:N/UI:P/VC:N/VI:N/VA:N/SC:N/SI:H/SA:N
Description
Summary
An attacker can use the next parameter on the login page to redirect a victim to a malicious page, while masking this using a legit-looking app.khoj.dev url.
For example, https://app.khoj.dev/login?next=//example.com will redirect to the https://example.com page.
Details
The problem seems to be in this method: https://github.com/khoj-ai/khoj/blob/2667ef45449eb408ce1d7c393be04845be31e15f/src/khoj/routers/auth.py#L95
PoC
Open the https://app.khoj.dev/login?next=//example.com url in a Gecko-based browser (Firefox).
Impact
The impact is low, and this could only be used in phishing attempts, but it's still a problem nonetheless.
CWEs
- CWE-601 · URL Redirection to Untrusted Site ('Open Redirect')
References
- https://github.com/khoj-ai/khoj/security/advisories/GHSA-564j-v29w-rqr6 ↗
- https://github.com/khoj-ai/khoj/commit/4daf16e5f916641304e11d56a6071ad365c21a18 ↗
- https://github.com/khoj-ai/khoj/blob/2667ef45449eb408ce1d7c393be04845be31e15f/src/khoj/routers/auth.py#L95 ↗
- https://github.com/advisories/GHSA-564j-v29w-rqr6 ↗