openzeppelin/openzeppelin-contracts · Security
OpenZeppelin Contracts TransparentUpgradeableProxy clashing selector calls may not be delegated
- GHSA ID
- GHSA-mx2q-35m2-x2rh
- CVE ID
- CVE-2023-30541
- Severity
- medium
- Published
- Updated
- CVSS
- 5.3 · CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:L
- CVSS v3
- 5.3 · CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:L
Description
Impact
A function in the implementation contract may be inaccessible if its selector clashes with one of the proxy's own selectors. Specifically, if the clashing function has a different signature with incompatible ABI encoding, the proxy could revert while attempting to decode the arguments from calldata.
The probability of an accidental clash is negligible, but one could be caused deliberately.
Patches
The issue has been fixed in v4.8.3.
Workarounds
If a function appears to be inaccessible for this reason, it may be possible to craft the calldata such that ABI decoding does not fail at the proxy and the function is properly proxied through.
References
https://github.com/OpenZeppelin/openzeppelin-contracts/pull/4154
CWEs
- CWE-436 · Interpretation Conflict
References
- https://github.com/OpenZeppelin/openzeppelin-contracts/security/advisories/GHSA-mx2q-35m2-x2rh ↗
- https://github.com/OpenZeppelin/openzeppelin-contracts/pull/4154 ↗
- https://nvd.nist.gov/vuln/detail/CVE-2023-30541 ↗
- https://github.com/OpenZeppelin/openzeppelin-contracts/releases/tag/v4.8.3 ↗
- https://github.com/OpenZeppelin/openzeppelin-contracts-upgradeable/commit/58fa0f81c4036f1a3b616fdffad2fd27e5d5ce21 ↗
- https://github.com/advisories/GHSA-mx2q-35m2-x2rh ↗