propelorm/propel · Security
propel/propel1 SQL injection possible with limit() on MySQL
- GHSA ID
- GHSA-7g7c-qhf3-x59p
- Severity
- critical
- Published
- Updated
- CVSS
- 9.8 · CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:H/A:H
- CVSS v3
- 9.8 · CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:H/A:H
Description
The limit() query method is susceptible to catastrophic SQL injection with MySQL.
For example, given a model User for a table users:
UserQuery::create()->limit('1;DROP TABLE users')->find();
This will drop the users table!
The cause appears to be a lack of integer casting of the limit input in either Criteria::setLimit() or in DBMySQL::applyLimit(). The code comments there seem to imply that casting was avoided due to overflow issues with 32-bit integers.
This is surprising behavior since one of the primary purposes of an ORM is to prevent basic SQL injection.
This affects all versions of Propel: 1.x, 2.x, and 3.
CWEs
- CWE-89 · Improper Neutralization of Special Elements used in an SQL Command ('SQL Injection')
References
- https://github.com/propelorm/Propel/issues/1052 ↗
- https://github.com/propelorm/Propel/pull/1054 ↗
- https://github.com/propelorm/Propel/commit/b72093201f8e225410f62a246653ac039e31c90a ↗
- https://github.com/FriendsOfPHP/security-advisories/blob/master/propel/propel1/2018-02-14.yaml ↗
- https://github.com/advisories/GHSA-7g7c-qhf3-x59p ↗