py-pdf/pypdf · Security
PyPDF2 vulnerable to possible Infinite Loop when reading malformed objects
- GHSA ID
- GHSA-hm9v-vj3r-r55m
- CVE ID
- CVE-2023-36807
- Severity
- medium
- Published
- Updated
- CVSS
- 6.2 · CVSS:3.1/AV:L/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H
- CVSS v3
- 6.2 · CVSS:3.1/AV:L/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H
Description
Impact
An attacker who uses this vulnerability can craft a PDF which leads to an infinite loop. This infinite loop blocks the current process and can utilize a single core of the CPU by 100%. It does not affect memory usage. That is, for example, the case if the user extracted metadata from such a malformed PDF.
Patches
The issue was fixed with https://github.com/py-pdf/pypdf/pull/1331
Workarounds
If you cannot update your version of PyPDF2 (preferably to pypdf>3.1.0 as PyPDF2 is deprecated), you should modify PyPDF2/generic/_data_structures.py::read_object.
Replace:
else:
# number object OR indirect reference
peek = stream.read(20)
stream.seek(-len(peek), 1) # reset to start
if IndirectPattern.match(peek) is not None:
return IndirectObject.read_from_stream(stream, pdf)
else:
return NumberObject.read_from_stream(stream)
by
elif tok in b"0123456789+-.":
# number object OR indirect reference
peek = stream.read(20)
stream.seek(-len(peek), 1) # reset to start
if IndirectPattern.match(peek) is not None:
return IndirectObject.read_from_stream(stream, pdf)
else:
return NumberObject.read_from_stream(stream)
else:
raise PdfReadError(
f"Invalid Elementary Object starting with {tok} @{stream.tell()}"
)
References
CWEs
- CWE-835 · Loop with Unreachable Exit Condition ('Infinite Loop')
References
- https://github.com/py-pdf/pypdf/security/advisories/GHSA-hm9v-vj3r-r55m ↗
- https://nvd.nist.gov/vuln/detail/CVE-2023-36807 ↗
- https://github.com/py-pdf/pypdf/issues/1329 ↗
- https://github.com/py-pdf/pypdf/pull/1331 ↗
- https://github.com/py-pdf/pypdf/commit/e6531a25325e7e0174b6a1ba03b57320b5227f6b ↗
- https://github.com/advisories/GHSA-hm9v-vj3r-r55m ↗