vyperlang/vyper · Security
Vyper: Call stack corruption when passing complex type containing non-base type members as argument
- GHSA ID
- GHSA-4v7v-gqf9-ww2g
- Severity
- medium
- Published
- Updated
- CVSS v4
- 6.9 · CVSS:4.0/AV:N/AC:L/AT:N/PR:N/UI:N/VC:N/VI:L/VA:N/SC:N/SI:N/SA:N
Description
Impact
When we pass a multi-dimensional array (like [[1, 2], [3, 4]]) as an argument to internal/external functions we get incorrect output. This is due to a stack management issue, because it was assumed that the size of each subtype of an array/struct is 32, which is not always correct.
Example code:
@internal
def test_input(arr: int128[2][1], i: int128) -> (int128[2][1], int128):
return arr, i
@external
def test_values(arr: int128[2][1], i: int128) -> (int128[2][1], int128):
return self.test_input(arr, i)
Please see #2183 for further information
Patches
This problem was fixed in #2184, and released as a part of v0.2.6.
CWEs
- CWE-682 · Incorrect Calculation
References
- https://github.com/vyperlang/vyper/security/advisories/GHSA-4v7v-gqf9-ww2g ↗
- https://github.com/vyperlang/vyper/issues/2183 ↗
- https://github.com/vyperlang/vyper/pull/2184 ↗
- https://github.com/vyperlang/vyper/commit/0be02b7331e8febe79d5a4218829c72e30417a29 ↗
- https://github.com/vyperlang/vyper/releases/tag/v0.2.6 ↗
- https://github.com/advisories/GHSA-4v7v-gqf9-ww2g ↗