vyperlang/vyper · Security
Vyper's `_abi_decode` input not validated in complex expressions
- GHSA ID
- GHSA-cx2q-hfxr-rj97
- CVE ID
- CVE-2023-42460
- Severity
- medium
- Published
- Updated
- CVSS
- 5.3 · CVSS:3.1/AV:N/AC:H/PR:L/UI:N/S:U/C:N/I:H/A:N
- CVSS v3
- 5.3 · CVSS:3.1/AV:N/AC:H/PR:L/UI:N/S:U/C:N/I:H/A:N
- CVSS v4
- 6 · CVSS:4.0/AV:N/AC:L/AT:P/PR:L/UI:N/VC:N/VI:H/VA:N/SC:N/SI:N/SA:N
Description
Impact
_abi_decode() does not validate input when it is nested in an expression. the following example gets correctly validated (bounds checked):
x: int128 = _abi_decode(slice(msg.data, 4, 32), int128)
however, the following example is not bounds checked
@external
def abi_decode(x: uint256) -> uint256:
a: uint256 = convert(_abi_decode(slice(msg.data, 4, 32), (uint8)), uint256) + 1
return a # abi_decode(256) returns: 257
the issue can be triggered by constructing an example where the output of _abi_decode is not internally passed to make_setter (an internal codegen routine) or other input validating routine.
Patches
https://github.com/vyperlang/vyper/pull/3626
Workarounds
Is there a way for users to fix or remediate the vulnerability without upgrading?
References
Are there any links users can visit to find out more?
CWEs
- CWE-682 · Incorrect Calculation
References
- https://github.com/vyperlang/vyper/security/advisories/GHSA-cx2q-hfxr-rj97 ↗
- https://nvd.nist.gov/vuln/detail/CVE-2023-42460 ↗
- https://github.com/vyperlang/vyper/pull/3626 ↗
- https://github.com/pypa/advisory-database/tree/main/vulns/vyper/PYSEC-2023-191.yaml ↗
- https://github.com/advisories/GHSA-cx2q-hfxr-rj97 ↗